-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cache SW manual test infrastructure #6532
Add Cache SW manual test infrastructure #6532
Conversation
Looks good including the move of the extension code into a file with less deps. But don't you need to update some unit tests there? |
Yup, working on that next. |
@jridgewell Are there actually any changes to how we calculate extension URL? Or is it just refactoring to a separate module? |
No changes to how they're done, just extracted and added |
For some god awful reason, all of our polyfills were being pulled into the SW code because of the dependency chains.
The old code prevented a base directory from being used, like if we were serving from `http://localhost/dist`
bfc33f9
to
528873f
Compare
528873f
to
6e65f6a
Compare
f840e46
to
7d01922
Compare
PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one comment.
@@ -108,7 +108,7 @@ runner.run('Cache SW', () => { | |||
'https://cdn.ampproject.org/rtv/123/v0.js'); | |||
}); | |||
|
|||
it('rewrites v1 to versioned v1', () => { | |||
it.skip('rewrites v1 to versioned v1', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because we don't match v1
right now, only v0
.
* Extract extensions-location from extensions-impl For some god awful reason, all of our polyfills were being pulled into the SW code because of the dependency chains. * Create calculateEntryPointScriptUrl * Ensure SW installs max code when asked * Update pathname rewriting in SW The old code prevented a base directory from being used, like if we were serving from `http://localhost/dist` * Add Cache SW manual test infrastructure * Remove unused export * Add tests * Fix tests
* Extract extensions-location from extensions-impl For some god awful reason, all of our polyfills were being pulled into the SW code because of the dependency chains. * Create calculateEntryPointScriptUrl * Ensure SW installs max code when asked * Update pathname rewriting in SW The old code prevented a base directory from being used, like if we were serving from `http://localhost/dist` * Add Cache SW manual test infrastructure * Remove unused export * Add tests * Fix tests
Fixes #6495.
/cc @dvoytenko for the extensions script url changes